feat(health): support various policies _.microgateway.airlock.com#28268
Open
root30 wants to merge 3 commits into
Open
feat(health): support various policies _.microgateway.airlock.com#28268root30 wants to merge 3 commits into
root30 wants to merge 3 commits into
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Bundle ReportBundle size has no change ✅ |
root30
force-pushed
the
resource-customizations-microgateway-policies
branch
from
016b61e to
90bd417
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #28268 +/- ##
=========================================
Coverage ? 65.05%
=========================================
Files ? 425
Lines ? 59292
Branches ? 0
=========================================
Hits ? 38575
Misses ? 17147
Partials ? 3570 ☔ View full report in Codecov by Harness. |
crenshaw-dev
requested changes
Jun 12, 2026
Signed-off-by: Roman Willi <roman.willi@ergon.ch>
root30
force-pushed
the
resource-customizations-microgateway-policies
branch
from
5632d45 to
c8d02c1
Compare
… microgateway.airlock.com API group Signed-off-by: Roman Willi <roman.willi@ergon.ch>
root30
force-pushed
the
resource-customizations-microgateway-policies
branch
from
c8d02c1 to
eddfbc9
Compare
Comment on lines
+33
to
+34
| hs.status = "Healthy" | ||
| hs.message = (obj.kind or "Policy") .. " is healthy" |
Member
There was a problem hiding this comment.
My reading of this is that if any ancestor is healthy, we'll basically ignore any ancestors that are still progressing but that do not yet have the Accepted condition yet... Maybe the "Healthy" path should be a final loop that confirms that all ancestors are healthy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the custom health check for various policy Types of Airlock Microgateway.
Checklist: